Do not show instructions for failed build #457
Merged
+38
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 37s |
kapr200
force-pushed
the
fix/copr_build_instructions
branch
from
d3442d1
to
0bbaf1d
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 28s |
Venefilyn
approved these changes
Sep 26, 2024
Comment on lines
+80
to
+112
| <> | ||
| <Card> | ||
| <CardBody> | ||
| <Text component="p"> | ||
| <strong> | ||
| You can install the built RPMs by following these steps: | ||
| </strong> | ||
| </Text> | ||
| <br /> | ||
| <List> | ||
| <ListItem> | ||
| <code>sudo dnf install -y dnf-plugins-core</code> | ||
| </ListItem> | ||
| <ListItem> | ||
| <code> | ||
| sudo dnf copr enable {data.copr_owner}/{data.copr_project} | ||
| </code> | ||
| </ListItem> | ||
| <ListItem> | ||
| <code> | ||
| sudo dnf install -y{" "} | ||
| {getPackagesToInstall(data.built_packages).join(" ")} | ||
| </code> | ||
| </ListItem> | ||
| </List> | ||
| <Text component="p"> | ||
| <br /> | ||
| Please note that the RPMs should be used only in a testing | ||
| environment. | ||
| </Text> | ||
| </CardBody> | ||
| </Card> | ||
| </> |
There was a problem hiding this comment.
Small comment, don't need React Fragment here <> as we only need it when there are multiple top-level components. Here we just have <Card>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
TODO:
packit/packit.dev.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Don't show instructions for installation when build fails
RELEASE NOTES END